Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): ignore .test. and test tsx files with buildable swc libraries #9540

Merged
merged 1 commit into from Apr 11, 2022

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

not ignoring files that tsc libraries ignore (test tsx files)

Expected Behavior

ignores .test. and TSX files

Related Issue(s)

Fixes #9442

@nx-cloud
Copy link

nx-cloud bot commented Mar 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 53057d9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/FW7ZgqexiWX7HLj4u7sgStGrMxuP
✅ Preview: Canceled

[Deployment for 53057d9 canceled]

@barbados-clemens barbados-clemens self-assigned this Mar 25, 2022
@barbados-clemens barbados-clemens added scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx scope: js labels Mar 25, 2022
@barbados-clemens barbados-clemens changed the title fix(js): ignore tsx and .test. files with buildable swc libraries fix(js): ignore .test. and test tsx files with buildable swc libraries Mar 25, 2022
include update to simplify existing patterns

ISSUES CLOSED: #9442
@barbados-clemens barbados-clemens merged commit 696fefd into master Apr 11, 2022
FrozenPandaz pushed a commit that referenced this pull request Apr 13, 2022
)

include update to simplify existing patterns

ISSUES CLOSED: #9442

Co-authored-by: Caleb Ukle <caleb@Calebs-MBP-2.localdomain>
@FrozenPandaz FrozenPandaz deleted the fix/swc-exclude branch June 7, 2022 23:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: js scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default 'exclude' config for swc don't include all test file extensions
2 participants