Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): un-scope the node_modules entry in generated .gitignore #9544

Merged
merged 1 commit into from Mar 28, 2022

Conversation

melanieseltzer
Copy link
Contributor

ISSUES CLOSED: #9412

Current Behavior

The node_modules entry has a leading slash. This scopes to the directory level of the .gitignore (only ignores node_modules at the same level of the .gitignore).

Expected Behavior

Ignore node_modules at all levels.

Related Issue(s)

Fixes #9412

@nx-cloud
Copy link

nx-cloud bot commented Mar 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0db5e43. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/Dv9jxLy9s87Puj1oQz2X2oMqo3JG
✅ Preview: Canceled

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 9a16371 into nrwl:master Mar 28, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.gitignore generated from create-nx-workspace allows nested node_modules to be committed
2 participants