Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storybook): import builder from core-server, not core #9562

Merged
merged 1 commit into from Mar 29, 2022
Merged

feat(storybook): import builder from core-server, not core #9562

merged 1 commit into from Mar 29, 2022

Conversation

mandarini
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #9286

@mandarini mandarini requested a review from juristr March 28, 2022 16:25
@nx-cloud
Copy link

nx-cloud bot commented Mar 28, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 765b1e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 11 targets

Sent with 💌 from NxCloud.

@mandarini mandarini self-assigned this Mar 28, 2022
@vercel
Copy link

vercel bot commented Mar 28, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5Ln6WKCys6Na5sfKRgRwme9d7YYy
✅ Preview: https://nx-dev-git-fork-mandarini-feat-storybook-core-server-nrwl.vercel.app

@mandarini mandarini requested a review from Coly010 March 29, 2022 12:11
Coly010
Coly010 requested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@Coly010 Coly010 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have one comment about the migration target just.

packages/storybook/migrations.json Outdated Show resolved Hide resolved
@mandarini mandarini requested a review from Coly010 March 29, 2022 13:58
Coly010
Coly010 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@mandarini mandarini enabled auto-merge (squash) March 29, 2022 14:17
@mandarini mandarini merged commit f3dde18 into nrwl:master Mar 29, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@mandarini @sidmonta
feat(storybook): import builder from core-server, not core (nrwl#9562)
acf5250
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Coly010 Coly010 Coly010 approved these changes

@juristr juristr Awaiting requested review from juristr

Assignees

@mandarini mandarini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"@nrwl/storybook:storybook" uses proxy package for "@storybook/core-server"
2 participants
@mandarini @Coly010