fix(devkit): add missing parameter to prettier getFileInfo #9577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/9gZL5Aw9ScS813StbkgwUvFwoK2m [Deployment for bb6f1ea canceled] |
danjor
force-pushed
the
fix/fix-format-files-to-allow-ignoring-files-from-prettierrc
branch
from
0ee76ab
to
8ff0358
Compare
danjor
force-pushed
the
fix/fix-format-files-to-allow-ignoring-files-from-prettierrc
branch
from
8ff0358
to
959dfcc
Compare
AgentEnder
reviewed
Mar 29, 2022
| @@ -32,7 +32,7 @@ export async function formatFiles(tree: Tree): Promise<void> { | |||
| await Promise.all( | |||
| Array.from(files).map(async (file) => { | |||
| const systemPath = path.join(tree.root, file.path); | |||
| let options: Prettier.Options = { | |||
| let options: any = { | |||
There was a problem hiding this comment.
There's probably a different type we can use here. Can you try Prettier.FileInfoOptions?
There was a problem hiding this comment.
Error: packages/devkit/src/generators/format-files.ts:36:9 - error TS2322: Type '{ filepath: string; }' is not assignable to type 'FileInfoOptions'.
Object literal may only specify known properties, and 'filepath' does not exist in type 'FileInfoOptions'.
36 filepath: systemPath,
There was a problem hiding this comment.
Ah, yes. Try Prettier.Options & Prettier.FileInfoOptions
danjor
force-pushed
the
fix/fix-format-files-to-allow-ignoring-files-from-prettierrc
branch
from
25ee660
to
11f6cf3
Compare
AgentEnder
changed the title
danjor
force-pushed
the
fix/fix-format-files-to-allow-ignoring-files-from-prettierrc
branch
from
11f6cf3
to
bb6f1ea
Compare
sidmonta
pushed a commit
to sidmonta/nx
that referenced
this pull request
Apr 2, 2022
Co-authored-by: Jordan CALVI <jordan.calvi.external@atos.net>
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When settings "ignorePath": "./.prettierignore" inside .prettierrc file, this is ignored when running nx generator as the second parameter of prettier.getFileInfo is missing, so formatFiles always format all the files and ignore is always false.
Expected Behavior
When setting "ignorePath": "./.prettierignore" inside .prettierrc file, this configuration should be taken into account when running nx generator as the second parameter of prettier.getFileInfo, so formatFiles formatFiles that are not ignored based on the config.
Related Issue(s)
Fixes #9576