Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): normalize file path for node-hasher #9585

Merged
merged 1 commit into from Mar 29, 2022
Merged

fix(core): normalize file path for node-hasher #9585

merged 1 commit into from Mar 29, 2022

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Mar 29, 2022 •
edited

Node hasher paths need to be normalized, since on windows they return with '\\' instead of '/' and don't match keys in workspace configuration.

Fixes #9584
Fixes #9581

@nx-cloud
Copy link

nx-cloud bot commented Mar 29, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fd8ebf1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder requested a review from vsavkin March 29, 2022 13:51
@vercel
Copy link

vercel bot commented Mar 29, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5PaMZxrQwmQJLAy7HYrUgLFHT5PD
✅ Preview: Canceled

[Deployment for fd8ebf1 canceled]

@AgentEnder AgentEnder mentioned this pull request Mar 29, 2022
Closed
@AgentEnder
fix(core): normalize file path for node-hasher
fd8ebf1 
Node hasher paths need to be normalized, since on windows they return with '\' instead of '/' and don't match keys in workspace configuration.

Fixes nrwl#9584
Fixes nrwl#9581
@FrozenPandaz FrozenPandaz merged commit 9123665 into nrwl:master Mar 29, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@AgentEnder @sidmonta
fix(core): normalize file path for node-hasher (nrwl#9585)
d4131e5 
Node hasher paths need to be normalized, since on windows they return with '\' instead of '/' and don't match keys in workspace configuration.

Fixes nrwl#9584
Fixes nrwl#9581
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AgentEnder @FrozenPandaz