Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): improve migrations performance by using registry to fetch packages information #9592

Merged
merged 1 commit into from Mar 29, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

To resolve the migrations metadata the packages are installed in a temporary directory and the information is fetched for them. Packages are cached to avoid re-fetching them, but the cache key doesn't consider the actual resolved version causing some packages to be re-fetched when requested with a version that will resolve to the same.

Expected Behavior

The packages information needed for the migration can be obtained directly from the registry for most cases and only a few might need to fall back to do an installation. Also, the cache is now properly populated to avoid re-fetching the same package versions.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 29, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 240a971. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 29, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/4chwB9YbCWEN9rncGWAKR814n3pZ
✅ Preview: https://nx-dev-git-fork-leosvelperez-migrate-perf-improvements-nrwl.vercel.app

@FrozenPandaz FrozenPandaz merged commit bdc7334 into nrwl:master Mar 29, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@leosvelperez leosvelperez deleted the migrate-perf-improvements branch April 11, 2022 15:34
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants