Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): expose storybook component story generator #9606

Merged
merged 1 commit into from Mar 30, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Mar 30, 2022

Expose the component-story generator

NOTE: future work will be to streamline this a bit

@Coly010 Coly010 requested a review from juristr March 30, 2022 10:29
@Coly010 Coly010 self-assigned this Mar 30, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 84dda3c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 30, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/DmufDXeAfotKwhxXqERF5jFFv4CN
✅ Preview: https://nx-dev-git-fork-coly010-storybook-expose-component-story-nrwl.vercel.app

@AgentEnder
Copy link
Member

LGTM, should this also be added to an index.ts file somewhere?

@Coly010
Copy link
Contributor Author

Coly010 commented Mar 30, 2022

LGTM, should this also be added to an index.ts file somewhere?

No it’s already exported from our generators.ts :)

@AgentEnder AgentEnder merged commit e22bdd0 into nrwl:master Mar 30, 2022
@Coly010 Coly010 deleted the storybook/expose-component-story branch March 30, 2022 18:30
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants