Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): update packages #9613

Merged
merged 1 commit into from Mar 30, 2022
Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 30, 2022

This PR updates React to v18, with special consideration if React Native < 0.68 is installed.

Notes:

  • Manually migrate to React 18 with a check for any incompatible React Native versions
  • Include additional migrations for React and React Native in migration.json files
  • Temporarily fix react@17.0.2 for the React Native plugin -- which we'll remove in Nx 14 once react-native@0.68.0 is out

@nx-cloud
Copy link

nx-cloud bot commented Mar 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8888274. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 30, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/7FgrG9bPJ8gAW8JEtFwUQTxN6ah5
✅ Preview: Canceled

[Deployment for 8888274 canceled]

@jaysoo jaysoo enabled auto-merge (squash) March 30, 2022 13:21
@carlosrziegler
Copy link

Nice, I will ask about update :)

@jaysoo jaysoo force-pushed the feat-update-react-packages branch from 3f3d9b2 to 8888274 Compare March 30, 2022 17:38
@jaysoo jaysoo merged commit b02beb5 into nrwl:master Mar 30, 2022
@jaysoo jaysoo deleted the feat-update-react-packages branch March 30, 2022 17:53
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@MichaelDeBoey
Copy link
Contributor

MichaelDeBoey commented Apr 21, 2022

@jaysoo This PR is not updating the react, react-dom & react-test-renderer version, it's only adding react-is@18.0.0 in my package.json

This is caused by the fact that it's using the addDependenciesToPackageJson function, which is literally only adding dependencies, not updating them.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants