Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): remove default testTimeout value which overrides the je… #9616

Merged
merged 1 commit into from Mar 30, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

…st config

Current Behavior

Having a testTimeout of 5000 by default overrides the value in jest.config.js

Expected Behavior

There should be no default for jestTimeout in the executor. jest internally will have a default of 5000 so not much changes.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Mar 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b2ab688. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 30, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/6pa2fYhRZvcZreeV84niX7pVj4s7
✅ Preview: https://nx-dev-git-fork-frozenpandaz-fix-jest2-nrwl.vercel.app

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) March 30, 2022 15:32
@FrozenPandaz FrozenPandaz merged commit 1bc2298 into nrwl:master Mar 30, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant