Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): update ng-add generator so the migration result is more aligned with new nx workspaces #9630

Merged
merged 1 commit into from Mar 31, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

When migrating an Angular CLI workspace to an Nx workspace, the migrated workspace configuration is not aligned with new Nx workspaces.

Expected Behavior

The workspace configuration for a migrated Angular CLI workspace should be more aligned to new Nx workspaces.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 31, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 31, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c74fda2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/AeB4j5DCv4uuuYEPhsmUbcvnHYfW
✅ Preview: https://nx-dev-git-fork-leosvelperez-angular-sync-ng-add-ws-nrwl.vercel.app

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit 18776f6 into nrwl:master Mar 31, 2022
@leosvelperez leosvelperez deleted the angular/sync-ng-add-ws branch March 31, 2022 15:30
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants