Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): add support for async webpack configuration #9641

Merged
merged 1 commit into from Apr 1, 2022
Merged

feat(node): add support for async webpack configuration #9641

merged 1 commit into from Apr 1, 2022

Conversation

exocom
Copy link
Contributor

@exocom exocom commented Apr 1, 2022 •
edited

Current Behavior

Only support sync functions

Expected Behavior

To support sync and async functions matching how webpack works

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 1, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fb5eed6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 1, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/7TrF2zDUS2XzGxZH5QmDyLRFQsDP
✅ Preview: https://nx-dev-git-fork-exocom-async-webpack-config-nrwl.vercel.app

@everops-kalarrs everops-kalarrs mentioned this pull request Apr 1, 2022
Closed
FrozenPandaz
FrozenPandaz approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) April 1, 2022 22:43
@FrozenPandaz FrozenPandaz self-assigned this Apr 1, 2022
@FrozenPandaz FrozenPandaz merged commit f922381 into nrwl:master Apr 1, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@exocom @sidmonta
feat(node): add support for async webpack configuration (nrwl#9641)
028752b
@exocom exocom deleted the async-webpack-config branch April 2, 2022 13:28
sidmonta added a commit to sidmonta/nx that referenced this pull request Apr 4, 2022
@sidmonta
feat(node): add support for async webpack configuration (nrwl#9641)
683ffa7
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

Assignees

@FrozenPandaz FrozenPandaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@exocom @FrozenPandaz