Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): remove mismatched @nrwl/next from dependencies #9648

Merged
merged 1 commit into from Apr 1, 2022

Conversation

exocom
Copy link
Contributor

@exocom exocom commented Apr 1, 2022

Current Behavior

The @nrwl/next dependency appears in both dependencies & devDependencies with mismatched versions

Expected Behavior

One instance of a package, either dependencies or devDependencies. Leaving in dependencies.
One version of a package. Removed 13.10.0-beta.8

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 1, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 576b7cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/HpSaWtEJmQKAHdgtauLQrsp3rbQ8
✅ Preview: https://nx-dev-git-fork-exocom-fix-deps-nrwl.vercel.app

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 7fe6822 into nrwl:master Apr 1, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@exocom exocom deleted the fix-deps branch April 2, 2022 13:27
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants