Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): support migrating angular cli workspaces with multiple projects when keeping the angular cli layout #9649

Merged
merged 1 commit into from Apr 1, 2022

Conversation

leosvelperez
Copy link
Member

When migrating an Angular CLI workspace using the --preserve-angular-cli-layout flag, the individual projects of the workspace are not migrated, the Angular CLI layout structure and config is kept as-is and only the CLI is replaced with the Nx CLI. As such, workspaces with multiple projects should be able to be migrated and continue to work as expected.

Current Behavior

It's not possible to migrate an Angular CLI workspace that contains multiple projects when preserving the Angular CLI layout.

Expected Behavior

Should be able to migrate an Angular CLI workspace that contains multiple projects when preserving the Angular CLI layout.

Related Issue(s)

Fixes #

… projects when keeping the angular cli layout
@leosvelperez leosvelperez self-assigned this Apr 1, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 1, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0eb1a09. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/Cmebd7MuYTaBJiRuDgS2ukPRaCiS
✅ Preview: Canceled

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit 557b241 into nrwl:master Apr 1, 2022
@leosvelperez leosvelperez deleted the angular/ng-add-restrictions branch April 1, 2022 14:49
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants