Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): use build-storybook as a build target for all libs #9651

Merged
merged 1 commit into from Apr 1, 2022

Conversation

mandarini
Copy link
Member

Current Behavior

Our storybook-configuration executor would look for build targets in Angular projects, and if it found @nrwl/angular:ng-packagr-lite and @angular-devkit/build-angular:browser as executors, it would know it's looking at a build target, and it would specify the projectBuildConfig of that project for Storybook to use that build target.

However, ng-packagr-lite does not support more options about styles and stylePreprocessor options, so users who wanted to specify these, they would manually go and change the projectBuildConfig in their buildable Angular libs, for Storybook. Since that was the case for a few issues on GitHub, I think it is better to only point to the project's build target when @angular-devkit/build-angular:browser is used, and in all other cases point directly to build-storybook.

Expected Behavior

Only point to the project's build target when @angular-devkit/build-angular:browser is used, and in all other cases point directly to build-storybook.

@mandarini mandarini self-assigned this Apr 1, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 1, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 28b3be1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/GJM2eKWRopTAzDc5qa91SDU2xuDo
✅ Preview: Canceled

@mandarini mandarini requested a review from juristr April 1, 2022 15:00
@mandarini mandarini requested a review from Coly010 April 1, 2022 15:00
@mandarini mandarini added the scope: storybook Issues related to Storybook support in Nx label Apr 1, 2022
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@mandarini mandarini enabled auto-merge (squash) April 1, 2022 15:23
@mandarini mandarini merged commit 43eee23 into nrwl:master Apr 1, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: storybook Issues related to Storybook support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants