feat(storybook): add projectBuildConfig as an option in generator #9655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/HUnXsZZuLCe1gyDKKaQNCkB7PC1f |
mandarini
force-pushed
the
feat/storybook-specify-projectbuildconfig
branch
from
2870f9d
to
d4f46cd
Compare
Coly010
approved these changes
Apr 4, 2022
mandarini
force-pushed
the
feat/storybook-specify-projectbuildconfig
branch
from
75bf7a1
to
f3f4d6f
Compare
mandarini
force-pushed
the
feat/storybook-specify-projectbuildconfig
branch
from
f3f4d6f
to
519b40e
Compare
mandarini
force-pushed
the
feat/storybook-specify-projectbuildconfig
branch
from
519b40e
to
ceaf712
Compare
Co-authored-by: Colum Ferry <cferry09@gmail.com>
mandarini
force-pushed
the
feat/storybook-specify-projectbuildconfig
branch
from
ceaf712
to
9a92696
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
projectBuildConfigis set automatically when generating storybook configurationExpected Behavior
While setting the
projectBuildConfigautomatically is good for almost all cases, there are some niche cases where a user would want to specify a custom browser target, and not have to change it manually afterwards.Related Issue(s)
#9378
Fixes #9378