fix(react): pass correct configuration when reading build target options in dev-server executor #9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/DEwe9LDayQpE7g6B1sdjcas19ea5 [Deployment for b600871 canceled] |
jaysoo
force-pushed
the
fix/react-build-target-for-dev-server
branch
from
077028c
to
b681fff
Compare
jaysoo
force-pushed
the
fix/react-build-target-for-dev-server
branch
from
b681fff
to
12c0e26
Compare
jaysoo
force-pushed
the
fix/react-build-target-for-dev-server
branch
from
12c0e26
to
176a8dd
Compare
jaysoo
force-pushed
the
fix/react-build-target-for-dev-server
branch
from
176a8dd
to
8a74fc4
Compare
jaysoo
changed the title
jaysoo
force-pushed
the
fix/react-build-target-for-dev-server
branch
from
8a74fc4
to
b600871
Compare
FrozenPandaz
approved these changes
Apr 1, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and issue where there are conflicting
NODE_ENVvariables being used inDefinePlugin. There was a regression when we fixed #8932.The problem was that when reading build target, we did not pass the current configuration in, so it defaulted to
productionas specified innx.json(defaultConfiguration). This caused webpack to add its ownDefinePluginthat conflicted with our own.Closes #7924