Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): case sensitive file import with react app generator when … #9670

Merged
merged 2 commits into from Apr 5, 2022

Conversation

kaltepeter
Copy link
Contributor

…using the pascalCaseFiles option

Based on the flags passed into the react application generator it should use the appropriate casing
in the imports for the generated App.spec.tsx.

This only affected new react apps generated with
the --pascalCaseFiles flag on fully case-sensitive file systems, such as a Linux host running
docker Linux. Since it's likely people have already manually fixed it, I don't think a migration makes
sense.

closes nrwl/nx-examples#195

ISSUES CLOSED: #9666

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #9666

…using pascalCaseFiles option

Based on the flags passed into the react application generator it should use the appropiate casing
in the imports for the generated App.spec.tsx.

This only affected new react apps generated with
the `--pascalCaseFiles` flag on fully case sensitive file systems, such as a linux host running
docker linux. Since it's likely people have already manually fixed, I don't think a migration makes
sense.

fixes nrwl#9666, closes nrwl/nx-examples#195

ISSUES CLOSED: nrwl#9666
@nx-cloud
Copy link

nx-cloud bot commented Apr 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8055e6e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/HpgqEBkK3WJNNarVE6kPqtw56eWK
✅ Preview: Canceled

[Deployment for 8055e6e canceled]

@AgentEnder AgentEnder enabled auto-merge (squash) April 5, 2022 13:34
@AgentEnder AgentEnder merged commit 274c050 into nrwl:master Apr 5, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated react application with --pascalCaseFiles flag fails jest on case sensitive file systems
3 participants