Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): add --module option to component generator #9684

Merged
merged 1 commit into from Apr 5, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 5, 2022

Current Behavior

Our component generator does not support the --module flag.

Expected Behavior

Our component generator should support the --module flag.

@Coly010 Coly010 requested a review from juristr April 5, 2022 13:20
@Coly010 Coly010 self-assigned this Apr 5, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 5, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 46e239e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/FsNfL2dFeNFh5A5WKzMSA3WmkJDv
✅ Preview: https://nx-dev-git-fork-coly010-angular-fix-component-generator-nrwl.vercel.app

Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and LGTM

@Coly010 Coly010 force-pushed the angular/fix-component-generator branch from 098c837 to 46e239e Compare April 5, 2022 14:04
@Coly010 Coly010 merged commit e42069b into nrwl:master Apr 5, 2022
@Coly010 Coly010 deleted the angular/fix-component-generator branch April 5, 2022 14:37
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants