Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook): optional chain all includes #9707

Merged
merged 1 commit into from Apr 6, 2022
Merged

fix(storybook): optional chain all includes #9707

merged 1 commit into from Apr 6, 2022

Conversation

mandarini
Copy link
Member

ISSUES CLOSED: #9702

Current Behavior

Expected Behavior

Related Issue(s)

#9702

Fixes #9702

@mandarini mandarini self-assigned this Apr 6, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 6, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8ab295f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 6, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/8KUk9DnWpxhcMUzx6mudQ8rYHPc5
✅ Preview: Canceled

[Deployment for 8ab295f canceled]

@mandarini mandarini mentioned this pull request Apr 6, 2022
Closed
@mandarini mandarini requested a review from Coly010 April 6, 2022 12:14
Coly010
Coly010 approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@mandarini mandarini enabled auto-merge (squash) April 6, 2022 12:43
@mandarini mandarini merged commit d5e7af0 into nrwl:master Apr 6, 2022
@guyindepurker
Copy link

guyindepurker commented Apr 6, 2022 •
edited

How can i update and see this change? i try to update nx with nx migrate latest and the version didn’t change for me in packge.json

@mandarini
Copy link
Member Author

@guyindepurker this will be available in the next version of Nx, 13.10, which should be available soon. Let me know if you need any help in the meantime!

@mandarini
Copy link
Member Author

@guyindepurker https://github.com/nrwl/nx/releases/tag/13.10.0 13.10.0 is out, so you should be good to go!

@mandarini mandarini deleted the fix/storybook-includes branch June 3, 2022 09:48
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Coly010 Coly010 Coly010 approved these changes

Assignees

@mandarini mandarini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'includes' of undefined storybook-configuration
3 participants
@mandarini @guyindepurker @Coly010