Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add cacheStrategy, rulesdir and resolvePluginsRelativeTo flags to eslint executor #9709

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

The @nrwl/linter:eslint executor is missing some flags (cacheStrategy, rulesdir, and resolvePluginsRelativeTo) that are present in the @angular-eslint/builder:lint builder and that are part of the ESLint CLI. This prevents folks from being able to use them and it also prevents a seamless transition from an Angular CLI workspace to an Nx workspace using the @nrwl/linter:eslint executor.

Expected Behavior

The @nrwl/linter:eslint executor should support the cacheStrategy, rulesdir, and resolvePluginsRelativeTo flags.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 6, 2022
@vercel
Copy link

vercel bot commented Apr 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/H9DaspbL3fb4LYL4oDJ4FZ6soAXv
✅ Preview: https://nx-dev-git-fork-leosvelperez-linter-sync-schema-ang-316e03-nrwl.vercel.app

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leosvelperez!

@leosvelperez leosvelperez merged commit a64bba9 into nrwl:master Apr 7, 2022
@leosvelperez leosvelperez deleted the linter/sync-schema-angular-eslint branch April 7, 2022 14:49
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants