Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update local plugin resolution to use path utilities #9713

Merged

Conversation

AgentEnder
Copy link
Member

Current Behavior

Local plugin resolution may fail if project paths are similar. I.e.

workspace/
├─ README.md
├─ node_modules/
├─ packages/
│  ├─ nx/
│  │  ├─ index.ts
│  ├─ nx-plugin/
│  │  ├─ index.ts
├─ nx.json

Since the tsconfig path for nx-plugin starts with packages/nx, the local plugin resolved to the wrong package.

Expected Behavior

Local resolution doesn't pick the wrong package.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/Grz692viXVQdPVw2gLQkkxB6wcfB
✅ Preview: Canceled

[Deployment for 9095e81 canceled]

@AgentEnder AgentEnder force-pushed the fix/plugins/local-plugin-resolution branch from 767f2c0 to 9095e81 Compare April 6, 2022 18:12
@FrozenPandaz FrozenPandaz merged commit 8af847c into nrwl:master Apr 6, 2022
@marckassay
Copy link

@AgentEnder I just experienced this issue. Looking forward to your fix!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants