Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): replaceAppNameWithPath should not consider additional properties #9706 #9729

Merged
merged 1 commit into from Apr 8, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 7, 2022

Current Behavior

The util function replaces the appName with the path to the app. It ignores certain properties that should not be replaced.
defaultConfiguration and maximumError is not one of those properties.

If an app is called dev then it will have issues if the defaultConfiguration is development and it will replace it with a path.

maximumError conflicts with app names containing mb etc.

Expected Behavior

Do not consider defaultConfiguration or maximumError when replacing app name with path

Related Issue(s)

Fixes #9706

@Coly010 Coly010 requested a review from AgentEnder April 7, 2022 15:31
@Coly010 Coly010 self-assigned this Apr 7, 2022
@vercel
Copy link

vercel bot commented Apr 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/3wZxfH3weA6YXzBBtpSFf6rCSEF6
✅ Preview: Canceled

[Deployment for 3837632 canceled]

@AgentEnder
Copy link
Member

@Coly010 Should maximumError be added to the list as well? That is the specific key that was an issue in the linked ticket.

@Coly010
Copy link
Contributor Author

Coly010 commented Apr 7, 2022

It should! good catch. They did mention that key, I missed that. I focused on the serve error which was caused by default configuration

@Coly010 Coly010 force-pushed the core/fix-forbidden-property-list branch from fdbb07b to 3837632 Compare April 7, 2022 16:15
@Coly010 Coly010 changed the title fix(core): replaceAppNameWithPath should not consider defaultConfiguration #9706 fix(core): replaceAppNameWithPath should not consider additional properties #9706 Apr 7, 2022
@Coly010 Coly010 merged commit 9cef14d into nrwl:master Apr 8, 2022
@Coly010 Coly010 deleted the core/fix-forbidden-property-list branch April 8, 2022 14:33
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with generated angular project.json
2 participants