Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): add application schema options to mfe-remote #9752

Merged
merged 1 commit into from Apr 8, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 8, 2022

Current Behavior

mfe-remote generator is missing some standard options from the application generator that should be included

Expected Behavior

include the additional application generator options

@Coly010 Coly010 self-assigned this Apr 8, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 8, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit aca778a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/HmBxAXfY9M7fWMAtCbJVdVjuCsig
✅ Preview: https://nx-dev-git-fork-coly010-angular-fix-mfe-remote-schema-nrwl.vercel.app

[Deployment for aca778a canceled]

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 enabled auto-merge (squash) April 8, 2022 14:29
@Coly010 Coly010 force-pushed the angular/fix-mfe-remote-schema branch from 05ec7a3 to aca778a Compare April 8, 2022 14:54
@Coly010 Coly010 merged commit 5b105b1 into nrwl:master Apr 8, 2022
@Coly010 Coly010 deleted the angular/fix-mfe-remote-schema branch April 8, 2022 15:46
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants