Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro Frontend Host generation uses CSS not --style or NX.json config #9760

Closed
pandabuilt opened this issue Apr 8, 2022 · 4 comments
Closed
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@pandabuilt
Copy link

Using NX as a monorepo with microfrontends - generating both host and remote
npx nx g @nrwl/angular:host app-shell

npx nx g @nrwl/angular:remote login --host=app-shell

I tried passing style=scss and no dice.

I also tried generating an app with mfe and host as the type - but then ran into other micro front end modular federation problems.

note that when I created it - it created "css" inside nx.json inside angular:application. I changed that to scss and even generated / regenerated host / remotes - and it still used css .

{ "npmScope": "app", "affected": { "defaultBase": "master" }, "implicitDependencies": { "angular.json": "*", "package.json": "*", "tslint.json": "*", ".eslintrc.json": "*", "nx.json": "*", "tsconfig.base.json": "*" }, "$schema": "./node_modules/@angular/cli/lib/config/schema.json", "cli": { "defaultCollection": "@nrwl/angular" }, "generators": { "@nrwl/react": { "application": { "style": "scss", "linter": "eslint", "babel": true }, "component": { "style": "scss" }, "library": { "style": "scss", "linter": "eslint" } }, "@nrwl/angular:application": { "style": "scss", "linter": "eslint", "unitTestRunner": "jest", "e2eTestRunner": "cypress" }, "@nrwl/angular:library": { "linter": "eslint", "unitTestRunner": "jest" }, "@nrwl/angular:component": { "style": "scss" } }, "defaultProject": "app" }

Current Behavior

Expected Behavior

Steps to Reproduce

This issue may not be prioritized if details are not provided to help us reproduce the issue.

Failure Logs

Environment

@gioragutt
Copy link
Contributor

Can you post the output of nx report?

@pandabuilt
Copy link
Author

pandabuilt commented Apr 9, 2022

 >  NX   Report complete - copy this into the issue template

   Node : 16.14.1
   OS   : darwin arm64
   npm  : 8.5.0
   
   nx : 13.10.0
   @nrwl/angular : 13.10.0
   @nrwl/cypress : 13.10.0
   @nrwl/detox : Not Found
   @nrwl/devkit : 13.1.3
   @nrwl/eslint-plugin-nx : 13.10.0
   @nrwl/express : Not Found
   @nrwl/jest : 13.10.0
   @nrwl/js : 13.9.7
   @nrwl/linter : 13.10.0
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : 13.9.7
   @nrwl/react-native : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : 13.10.0
   @nrwl/web : 13.9.7
   @nrwl/workspace : 13.9.7
   typescript : 4.5.5
   rxjs : 7.5.4
   ---------------------------------------
   Community plugins:
   	 @nxtend/firebase: 12.1.0
   	 @nativescript/nx: 3.0.10
   	 @ngneat/tailwind: 7.0.3

(node:53772) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /Users/a/app/node_modules/tslib/package.json.
Update this package.json to use a subpath pattern like "./*".
(Use `node --trace-deprecation ...` to show where the warning was created)

@Coly010 Coly010 added the scope: angular Issues related to Angular support in Nx label Apr 9, 2022
@Coly010 Coly010 self-assigned this Apr 9, 2022
@Coly010
Copy link
Contributor

Coly010 commented Apr 9, 2022

Fixed by this: #9751
and released in 13.10.1.

Thanks for reporting!

I'll close this as it has been addressed already

@Coly010 Coly010 closed this as completed Apr 9, 2022
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Development

No branches or pull requests

3 participants