Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.10.0 - Cypress does not respect env cli params (regression) #9764

Closed
danr-za opened this issue Apr 9, 2022 · 2 comments · Fixed by #9812
Closed

v13.10.0 - Cypress does not respect env cli params (regression) #9764

danr-za opened this issue Apr 9, 2022 · 2 comments · Fixed by #9812
Assignees
Labels
outdated scope: core core nx functionality scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: bug

Comments

@danr-za
Copy link
Contributor

danr-za commented Apr 9, 2022

Current Behavior

Seems like a regression of #8723

   Node : 16.13.0
   OS   : darwin x64
   yarn : 3.2.0
   
   nx : 13.10.1
   @nrwl/angular : Not Found
   @nrwl/cypress : 13.10.1
   @nrwl/detox : Not Found
   @nrwl/devkit : 13.10.1
   @nrwl/eslint-plugin-nx : 13.10.1
   @nrwl/express : Not Found
   @nrwl/jest : 13.10.1
   @nrwl/js : 13.10.1
   @nrwl/linter : 13.10.1
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : 13.10.1
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : 13.10.1
   @nrwl/react-native : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : 13.10.1
   @nrwl/web : 13.10.1
   @nrwl/workspace : 13.10.1
   typescript : 4.6.3
   rxjs : 6.6.7
   ---------------------------------------
   Community plugins:
         nx-stylelint: 13.3.0
@AgentEnder AgentEnder added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Apr 12, 2022
barbados-clemens added a commit that referenced this issue Apr 12, 2022
parse dot notation cli args for env args passed to cypress executor to override cypress.env.json
values.
i.e. nx e2e project --env.API_URL=localhost:1234
will now correctly give cypress e2e args to
override the cypress.env.json values

ISSUES CLOSED: #9764
@barbados-clemens
Copy link
Contributor

this looks to be an issue with what the executor is provided via nx.
as cypress executor is given the env vars just still in dot notation

nx v12
console log showing env vars are parsed as an object

nx v13
console log showing env vars are still in dot notation

looks to be a regression when we shuffled around the inner guts of nx on commit d4b5c30

here is the PR to fix it

@barbados-clemens barbados-clemens self-assigned this Apr 12, 2022
@barbados-clemens barbados-clemens added the scope: core core nx functionality label Apr 12, 2022
barbados-clemens added a commit that referenced this issue Apr 13, 2022
parse dot notation cli args for env args passed to cypress executor to override cypress.env.json
values.
i.e. nx e2e project --env.API_URL=localhost:1234
will now correctly give cypress e2e args to
override the cypress.env.json values

ISSUES CLOSED: #9764
barbados-clemens added a commit that referenced this issue Apr 14, 2022
parse dot notation cli args for env args passed to cypress executor to override cypress.env.json
values.
i.e. nx e2e project --env.API_URL=localhost:1234
will now correctly give cypress e2e args to
override the cypress.env.json values

ISSUES CLOSED: #9764
FrozenPandaz pushed a commit that referenced this issue Apr 14, 2022
parse dot notation cli args for env args passed to cypress executor to override cypress.env.json
values.
i.e. nx e2e project --env.API_URL=localhost:1234
will now correctly give cypress e2e args to
override the cypress.env.json values

ISSUES CLOSED: #9764
FrozenPandaz pushed a commit that referenced this issue Apr 19, 2022
parse dot notation cli args for env args passed to cypress executor to override cypress.env.json
values.
i.e. nx e2e project --env.API_URL=localhost:1234
will now correctly give cypress e2e args to
override the cypress.env.json values

ISSUES CLOSED: #9764
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: core core nx functionality scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants