fix(core): init generators should not crash when trying to remove dependencies when package.json does not have dependencies #9765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
some init generators (at least
web
andnode
) had edge cases where, when they would not invoke other init generators, they would crash when trying to delete dependencies frompackage.json
, because it wouldn't have a"dependencies"
key.Expected Behavior
When there's no
"dependencies"
(or dev/peer/optional) in package.json, generators should not crash when trying to alter it.This PR resolves this issue by using the
removeDependenciesFromPackageJson
method from devkit, instead of the more manualupdateJson
, in all applicable places where such an action happens.There are several places where I opted not to update them, they were all migrators doing something specific, and I preferred to stick to the problem at hand.
Related Issue(s)
Fixes #9763