Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): provide descriptive message when project is missing targets for cypress-project generator #9795

Merged
merged 1 commit into from Apr 12, 2022

Conversation

barbados-clemens
Copy link
Contributor

when trying to add cypress to a project that does not contain a serve target the project will error
out because of a null reference.
Now when trying to add to a project without a serve target a more
descriptive error is throw stating to add a serve target or use the --baseUrl flag

Note: a future update should add the parameter to override what target to use if so desired.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #9756

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Apr 11, 2022
@barbados-clemens barbados-clemens self-assigned this Apr 11, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 11, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5864b41. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 18 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/Ec7YSxdo9YteSsKatmZtqVfo2KBp
✅ Preview: Canceled

[Deployment for 5864b41 canceled]

@barbados-clemens barbados-clemens changed the title fix(testing): provide descriptive error for missing target when adding cypress fix(testing): provide descriptive message for missing target when adding cypress Apr 12, 2022
…t does not have targets defined.

when trying to add cypress to a project that does not contain targets the project will error
out because of a null reference.
Now when trying to add to a project without a serve target a more
descriptive message is logged stating to add a serve target or use the --baseUrl flag
Note: a future
update should add the parameter to override what target to use if so desired.

ISSUES CLOSED: #9756
@barbados-clemens barbados-clemens changed the title fix(testing): provide descriptive message for missing target when adding cypress fix(testing): provide descriptive message when project is missing targets for cypress-project generator Apr 12, 2022
@barbados-clemens barbados-clemens merged commit 02cf4be into master Apr 12, 2022
@barbados-clemens barbados-clemens deleted the cypress-project-check-target branch April 12, 2022 19:39
FrozenPandaz pushed a commit that referenced this pull request Apr 13, 2022
…ave targets defined. (#9795)

when trying to add cypress to a project that does not contain targets the project will error
out because of a null reference.
Now when trying to add to a project without a serve target a more
descriptive message is logged stating to add a serve target or use the --baseUrl flag
Note: a future
update should add the parameter to override what target to use if so desired.

ISSUES CLOSED: #9756
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Generate Cypress Project on 13.10
2 participants