Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): add publish target and generate minimal publish script for … #9806

Merged
merged 3 commits into from Apr 12, 2022

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Apr 12, 2022

…publishable libraries

Expected Behavior

This is the first step to start getting into the Publishing story for Nx. Starting with nrwl/js

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 12, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f03cbc3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx-cloud record -- yarn check-commit
✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/GxRV29eB6jPCZCV7Hyedj2FmiXNg
✅ Preview: Canceled

[Deployment for f03cbc3 canceled]

@nartc nartc requested review from jaysoo and vsavkin April 12, 2022 14:31
Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some questions and comments

packages/js/src/utils/minimal-publish-script.ts Outdated Show resolved Hide resolved
packages/js/src/utils/minimal-publish-script.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good once the error message is updated to display a more helpful pattern of the version expected.

packages/js/src/utils/minimal-publish-script.ts Outdated Show resolved Hide resolved
Co-authored-by: Caleb Ukle <caleb@nrwl.io>
@nartc nartc merged commit 2735aa0 into master Apr 12, 2022
@FrozenPandaz FrozenPandaz deleted the publishable-lib-generator branch June 7, 2022 23:31
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants