fix(storybook): remove hard-coded ci:true option

[mandarini]

ISSUES CLOSED: #9681

Current Behavior

This issue is due to this line here.

  return buildDevStandalone({
    ...options,
    ci: true,

our hard-coded ci: true.

In the Storybook docs it says for the --ci option: "CI mode (skip interactive prompts, don't open browser)"

This line ci: true has been there since the beginning of time. It is believed to have been put there back in 2019 to avoid interactive prompts. Interactive prompts no longer happen, even if we remove the ci: true.

Here's the Storybook code for reference:

  if (!options.ci && !options.smokeTest && options.open) {

As to why for pure Storybook apps it opens automatically, it's because this transformation here adds the open: true option. We don't do this step in our server, because we use buildDevStandalone (we will use buildDev eventually):

  const cliOptions = await getDevCli(loadOptions.packageJson);

Expected Behavior

User can pass --open and it will not be ignored.

Related Issue(s)

#9681

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 27f01fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 13 targets

• nx affected --target=build --base=a162bfb420c2421319bdb7abdcefe7ecdc32fecb --head=27f01fc63f54e86aaffee6f1e1101f6d2dfb3b46 --parallel=3
• nx affected --target=e2e --base=a162bfb420c2421319bdb7abdcefe7ecdc32fecb --head=27f01fc63f54e86aaffee6f1e1101f6d2dfb3b46 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=a162bfb420c2421319bdb7abdcefe7ecdc32fecb --head=27f01fc63f54e86aaffee6f1e1101f6d2dfb3b46 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=a162bfb420c2421319bdb7abdcefe7ecdc32fecb --head=27f01fc63f54e86aaffee6f1e1101f6d2dfb3b46 --parallel=3
• nx affected --target=test --base=a162bfb420c2421319bdb7abdcefe7ecdc32fecb --head=27f01fc63f54e86aaffee6f1e1101f6d2dfb3b46 --parallel=1
• nx build typedoc-theme
• nx run-many --target=build --all --parallel=8 --exclude=docs,nx-dev-data-access-documents,nx-dev-e2e,nx-dev,nx-dev-feature-analytics,nx-dev-feature-conf,nx-dev-feature-doc-viewer,nx-dev-feature-search,nx-dev-feature-storage,nx-dev-feature-versions-and-flavors,nx-dev-ui-commands,nx-dev-ui-common,nx-dev-ui-home,nx-dev-ui-member-card,nx-dev-ui-sponsor...
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn documentation
• nx-cloud record -- yarn nx format:check --base=a162bfb420c2421319bdb7abdcefe7ecdc32fecb --head=27f01fc63f54e86aaffee6f1e1101f6d2dfb3b46
• nx-cloud record -- yarn nx workspace-lint

---

Sent with 💌 from NxCloud.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/84Jo5mqBEUHRNzbrtn57oZfWR2mt
✅ Preview: Ignored

[Deployment for 27f01fc canceled]

[Coly010]

Is the default behaviour with this change the same as it was before it? It'll run headlessly until the asks otherwise?

[Coly010]

LGTM! 🎉

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.