Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): path normalize was in correct on windows #9861 #9881

Merged
merged 1 commit into from Apr 19, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 19, 2022

Current Behavior

Path normalization for TSConfig paths in MF not working for non-Unix filesystems.

Expected Behavior

It should work regardless of OS

Related Issue(s)

Fixes #9861

@Coly010 Coly010 self-assigned this Apr 19, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b957a76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 14 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Apr 19, 2022 at 10:55AM (UTC)

@Coly010 Coly010 merged commit 5fb6fc7 into nrwl:master Apr 19, 2022
@Coly010 Coly010 deleted the angular/9861-mfe-path-normalize branch April 19, 2022 11:47
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular MFE Module build failed missing from the typescript compilation
2 participants