Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): align yargs options in workspace-generator with generic options passed into other commands #9953

Conversation

AgentEnder
Copy link
Member

Current behavior

Running nx workspace-generator my-generator --dry-run results in passing dry-run: true as an option to the workspace generator.

Expected behavior

Running nx workspace-generator my-generator --dry-run doesn't pass dry-run: true as an option to the workspace generator, since it would be omitted when running generators from a plugin.

@nx-cloud
Copy link

nx-cloud bot commented Apr 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit df93024. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx-cloud record -- yarn depcheck
✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Apr 22, 2022 at 2:04PM (UTC)

@AgentEnder AgentEnder merged commit 0ce7ce6 into nrwl:master Apr 26, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant