fix(core): fix postinstall failure due to project graph build error #9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Hi guys, How can I rerun the checks? According to the logs they failed due to a timeout: |
Delegate error handling to calling functions and avoid `process.exit(1)`, which causes the package's postinstall stage to fail if there are problems with the project graph Closes nrwl#9451
tommazzo89
force-pushed
the
fix/project-graph-postinstall-failure
branch
from
6bb1608
to
2d35a2c
Compare
FrozenPandaz
approved these changes
Apr 25, 2022
|
Great, thanks a lot @FrozenPandaz! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
postinstallhook of thenxpackage fails if aproject.jsonfile is missing. This can happen, e.g., during a Docker build, when the layer used fornpm install/npm cionly contains the workspace definition files (workspace.json,package.json, etc.) to enable caching of this step (see this comment for details).Expected Behavior
The
postinstallstep no longer fails, becausebuildProjectGraphWithoutDaemon()no longer exits the process with an error code (process.exit(1)) and, thus, allows the init script to catch the error.@ Nx maintainers: I don't know why the
process.exit(1)call was introduced in the first place. Thus, I don't know if removing it has any undesired side effects. In case there are any, please inform me what needs to be fixed.Related Issue(s)
Fixes #9451