Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix having multiple versions of nx/devkit #9998

Merged
merged 1 commit into from Apr 26, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

@nrwl/devkit brings in nx as a dependency which causes an issue where nx's postinstall is run multiple times. This causes some CI machines to run out of memory. Also, installing packages during generators, is able to dedupe installs during the same installation of devkit, but it is not able to dedupe across multiple versions of devkit.

Expected Behavior

@nrwl/devkit has a peer dependency on nx. The range for this dependency goes up a major version as we should keep nx compatible with devkit. This will fix having multiple versions of nx installed. This fixes some CI machines to run out of memory. Also, installing packages during generators, is able to dedupe installs across different installations of devkit.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cbac37b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 13 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 4:23PM (UTC)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant