From 867936c32f20ed80bd75e0881fc0e507afb7ab16 Mon Sep 17 00:00:00 2001 From: jaybell Date: Fri, 18 Feb 2022 13:19:05 -0800 Subject: [PATCH 1/3] fix(core): add more descriptive dependencies build error --- .../workspace/src/utilities/buildable-libs-utils.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/workspace/src/utilities/buildable-libs-utils.ts b/packages/workspace/src/utilities/buildable-libs-utils.ts index 13df071766199..9f86b893030e8 100644 --- a/packages/workspace/src/utilities/buildable-libs-utils.ts +++ b/packages/workspace/src/utilities/buildable-libs-utils.ts @@ -208,7 +208,15 @@ export function checkDependentProjectsHaveBeenBuilt( targetName, projectDependencies ); - if (missing.length > 0) { + if (missing.length === projectDependencies.length) { + console.error(stripIndents` + It looks like all of ${projectName}'s dependencies have not been built yet: + ${missing.map((x) => ` - ${x.node.name}`).join('\n')} + + You might be missing a "targetDependencies" configuration in your root nx.json (https://nx.dev/configuration/packagejson#target-dependencies), + or "dependsOn" configured in ${projectName}'s angular.json/workspace.json record or project.json (https://nx.dev/configuration/packagejson#dependson) + `); + } else if (missing.length > 0) { console.error(stripIndents` Some of the project ${projectName}'s dependencies have not been built yet. Please build these libraries before: ${missing.map((x) => ` - ${x.node.name}`).join('\n')} From c4e761b097fc6939dc982bfd2eddaceaa14d4154 Mon Sep 17 00:00:00 2001 From: Jay Bell Date: Wed, 23 Mar 2022 09:03:54 -0700 Subject: [PATCH 2/3] fix(core): check for no projects missing before showing error Co-authored-by: Craigory Coppola --- packages/workspace/src/utilities/buildable-libs-utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/workspace/src/utilities/buildable-libs-utils.ts b/packages/workspace/src/utilities/buildable-libs-utils.ts index 9f86b893030e8..7123a46f52bc8 100644 --- a/packages/workspace/src/utilities/buildable-libs-utils.ts +++ b/packages/workspace/src/utilities/buildable-libs-utils.ts @@ -208,7 +208,7 @@ export function checkDependentProjectsHaveBeenBuilt( targetName, projectDependencies ); - if (missing.length === projectDependencies.length) { +if (missing.length === projectDependencies.length && missing.length > 0) { console.error(stripIndents` It looks like all of ${projectName}'s dependencies have not been built yet: ${missing.map((x) => ` - ${x.node.name}`).join('\n')} From 26614df03569f3ea4c06e074dbf1b54b6baa68b3 Mon Sep 17 00:00:00 2001 From: Craigory Coppola Date: Mon, 28 Mar 2022 16:12:21 -0400 Subject: [PATCH 3/3] chore(repo): nx format --- packages/workspace/src/utilities/buildable-libs-utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/workspace/src/utilities/buildable-libs-utils.ts b/packages/workspace/src/utilities/buildable-libs-utils.ts index 7123a46f52bc8..cd386be7721ae 100644 --- a/packages/workspace/src/utilities/buildable-libs-utils.ts +++ b/packages/workspace/src/utilities/buildable-libs-utils.ts @@ -208,7 +208,7 @@ export function checkDependentProjectsHaveBeenBuilt( targetName, projectDependencies ); -if (missing.length === projectDependencies.length && missing.length > 0) { + if (missing.length === projectDependencies.length && missing.length > 0) { console.error(stripIndents` It looks like all of ${projectName}'s dependencies have not been built yet: ${missing.map((x) => ` - ${x.node.name}`).join('\n')}