fix image url with cloud providers #78
Conversation
|
@ovieokeh is it okay to use "https" as a checker? how if someone decide to use local provider and deploy it into remote https server |
You're right that's not a robust validation. I've switched to using the What do you think? @ahsetiaki |
|
have you tested that? honestly I can't comment further because I don't know about |
Yes it's tested and seems to work fine. But I only tested with the @provider-upload-aws-s3 provider so can't say if it works for Cloudinary as well (it should though as the |
|
@ovieokeh as long as this PR haven't merged, I think we have to clone it as plugin and customize by ourself, thanks btw |
| let urls = { default: defaultUrl }; | ||
| let keys = Object.keys(formats).sort( | ||
| (a, b) => formats[a].width - formats[b].width | ||
| ); | ||
| keys.map((k) => (urls[formats[k].width] = backendUrl + formats[k].url)); |
There was a problem hiding this comment.
Isn't there a mistake here too? I'm having the same problem now for the src set.
srcset="http://localhost:1337https://SPACE_PATH/870fd27ba154892bc07c9164bbbab4a2.png 64w"
What does it do?
This PR updates the
StrapiUploadAdapter.jsplugin to check for a full image url before prefixingbackendUrlto an uploaded image url.Why is it needed?
On Strapi instances with a cloud provider configured, images uploaded via the editor have a malformed URL. This breaks the editor preview as well.
The cause of the problem is that the StrapiUploadAdapter plugin automatically prepends every image upload url with the
backendUrlvariable resulting in image urls that look like this —Strapi Cloud Upload provider plugins like @strapi-community/strapi-provider-upload-google-cloud-storage and @provider-upload-aws-s3 return a fully formed url so there's no need to prepend the
backendUrl.Related issue(s)/PR(s)
#72