-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch webpack back to babel-loader #4004
Comments
Would switching back to babel would reintroduce #3594 due to babel/babel#8361? There's a discussion on the next.js repo about this problem related to HMR: vercel/next-plugins#306 |
We took the next.js apps out of the repo, so we won't run into that anymore. They'll use the transpiled packages. |
This issue hasn't had any activity on it in the last 90 days. Unfortunately we don't get around to dealing with every issue that is opened. Instead of leaving issues open we're seeking to be transparent by closing issues that aren't being prioritized. If no other activity happens on this issue in one week, it will be closed.
Thank you! |
We'll still need to do this. The work to introduce babel-loader has been introduced to our test workflows during the addition of ipywidgets support. We'll need to follow this through to the source code. |
This issue hasn't had any activity on it in the last 90 days. Unfortunately we don't get around to dealing with every issue that is opened. Instead of leaving issues open we're seeking to be transparent by closing issues that aren't being prioritized. If no other activity happens on this issue in one week, it will be closed.
Thank you! |
Closing this since we'll realistically not be able to handle this any time soon. |
As noted in https://github.com/gaearon/react-hot-loader/blob/master/README.md#typescript, in order to use
react-hot-loader
we have to use thebabel-loader
.During the conversion process to TypeScript I thought that in order for us to have type checking, I thought we'd have to switch over to
ts-loader
(for the sake of handling project references). It seems that we can set things up in a dual mode: type checking gets done with a rigorous tsconfig that uses project references while our webpack setup is allowed to usebabel-loader
+react-hot-loader
.The text was updated successfully, but these errors were encountered: