Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monaco perf improvement: Optimize editor.layout calls #5606

Open
vivek1729 opened this issue Oct 1, 2021 · 0 comments
Open

Monaco perf improvement: Optimize editor.layout calls #5606

vivek1729 opened this issue Oct 1, 2021 · 0 comments

Comments

@vivek1729
Copy link
Contributor

The layout method instructs the editor to remeasure itself and resize if the container has changed since the last update. Under the hood, the layout method tries to call some core DOM apis to get the size of the container DOM element iff there are no params passed to this method.

// Tells the editor pane to check if its container has changed size and fill appropriately
this.editor.layout();

It might be worth exploring if this call is needed here and if we can optimize it by passing some expected height/width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant