-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a rotating log file in addition to logging to the console #1534
Comments
Can you please provide few more details about this issue, i am new here so i would love to contribute on this |
The logs from the main process and the renderer process need to be saved to a file with a capped size. When the limit is reached, a new file needs to be created. When the limit in that file is reached, the next log should clear the oldest log file and start saving there. The number of log files and the limit should both be customizable. |
and from where it should be controlled? |
For now, it can be hardcoded in the logger initialization code. |
Hi @Tweniee, are you still working on this issue? |
Can I work on this if it is not resolved yet? Looks like there has been no activity since a while |
Sure, go ahead! |
Hey @nukeop!
|
We're using |
Got it! Thanks, will let you know if I have any more questions. |
The |
Sounds good if you can make it work with the current logging mechanism. |
I think this task can be taken up by any other person that is available. I am having a difficult time with the development environment, even though I am on Linux (mostly system specifications - low end PC). My findings that can help anyone: I wasn't able to find any library that does the rotation, by files at least. I was able to make it work a little bit with the |
Okay! There's been a bunch of people announcing they're working on this, then doing nothing. I think we've got the approach down already. All that's needed is a pull request, in any shape - we can iterate the solution. |
The log file needs to be stored in the same directory as the config files and never exceed 1-2MB.
The text was updated successfully, but these errors were encountered: