Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 2020s have not been supported on recent years' feedback #100

Closed
kxn4t opened this issue May 24, 2021 · 2 comments
Closed

The 2020s have not been supported on recent years' feedback #100

kxn4t opened this issue May 24, 2021 · 2 comments

Comments

@kxn4t
Copy link
Contributor

kxn4t commented May 24, 2021

The 1990s, 2000s, and 2010s are supported, but the 2020s do not seem to be supported.

It seems to be because it is not included in the regular expression of the matcher.
https://github.com/nulab/zxcvbn4j/blob/master/src/main/java/com/nulabinc/zxcvbn/matchers/RegexMatcher.java#L15
@vvatanabe
Copy link
Member

@kxn4t Thanks for feedbacks! I think we should add 2021. This will make the result slightly different from the origin, but the decision to add 2021 will be correct.

kxn4t added a commit to kxn4t/zxcvbn4j that referenced this issue Jun 7, 2021
@kxn4t
fix recent years nulab#100
b5cfba8 
Different from the origin, but added because it is now 2020s
https://github.com/dropbox/zxcvbn/blob/v4.4.2/src/matching.coffee#L38
kxn4t added a commit to kxn4t/zxcvbn4j that referenced this issue Jun 7, 2021
@kxn4t
fix test
8a48d6f 
fix test nulab#100
vvatanabe added a commit that referenced this issue Jun 7, 2021
@vvatanabe
Merge pull request #102 from kxn4t/fix-recent-years
f68162a 
fix recent years #100
@vvatanabe
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvatanabe @kxn4t