Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent score between zxcvbn4j and zxcvbn #50

Closed
kyneh opened this issue Jun 1, 2018 · 7 comments
Closed

Inconsistent score between zxcvbn4j and zxcvbn #50

kyneh opened this issue Jun 1, 2018 · 7 comments

Comments

@kyneh
Copy link

kyneh commented Jun 1, 2018

I get inconsistent scores for following values:

Password zxcvbn4j score zxcvbn score
5621127 2 1
61526611441 4 3
0078690420729 4 3
@StanKocken
Copy link

Thanks @kyneh, I would add as well zhang198822:
https://lowe.github.io/tryzxcvbn/ (zxcvbn score): 2 / 4
zxcvbn4j: 3 / 4

@TomLottermann
Copy link

Is there any news on this?
We're considering switching from nbvcxz since zxcvbn4j seems to be a more exact replica of zxcvbn.

@TomLottermann
Copy link

@vvatanabe: You were active last in this project. Do you maybe have an idea about where this difference might be coming from?

@vvatanabe
Copy link
Member

@TomLottermann I'm not sure the cause. It may take some time to investigate.

@vvatanabe
Copy link
Member

@TomLottermann
We found the cause of the problem. I'll release a fix today.

vvatanabe added a commit that referenced this issue Oct 28, 2020
vvatanabe added a commit that referenced this issue Oct 28, 2020
fix inconsistent score between zxcvbn4j and zxcvbn (#50)
@vvatanabe
Copy link
Member

@kyneh @StanKocken @TomLottermann
I fixed and released 1.3.1. Thanks!

@TomLottermann
Copy link

Wow that was fast!

Thanks a ton! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants