Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in method Feedback.getFeedback #82

Closed
mrFloony opened this issue Jan 22, 2021 · 2 comments
Closed

Error in method Feedback.getFeedback #82

mrFloony opened this issue Jan 22, 2021 · 2 comments

Comments

@mrFloony
Copy link

mrFloony commented Jan 22, 2021

The error is that to find the longest match, the first value in the list is taken, and then you form a sublist, but there are no values in this sublist.
Test results:

password: [justshort]
matches: 2
match index=0: Match{pattern=Dictionary, i=0, j=3, token=just, dictionaryName='us_tv_and_film'}
match index=1: Match{pattern=Dictionary, i=4, j=8, token=short, dictionaryName='english_wikipedia'}

matches sublist: 0

first longest=Match{pattern=Dictionary, i=0, j=3, token=just, dictionaryName='us_tv_and_film'}
last longest=Match{pattern=Dictionary, i=0, j=3, token=just, dictionaryName='us_tv_and_film'}

When forming sequence.subList, the toIndex parameter of the sublist method was specified incorrectly.
Test results:

password: [justshort]
matches: 2
match index=0: Match{pattern=Dictionary, i=0, j=3, token=just, dictionaryName='us_tv_and_film'}
match index=1: Match{pattern=Dictionary, i=4, j=8, token=short, dictionaryName='english_wikipedia'}

matches sublist: 1
match index=0: Match{pattern=Dictionary, i=4, j=8, token=short, dictionaryName='english_wikipedia'}

first longest=Match{pattern=Dictionary, i=0, j=3, token=just, dictionaryName='us_tv_and_film'}
replaced longest by match: Match{pattern=Dictionary, i=4, j=8, token=short, dictionaryName='english_wikipedia'}
last longest=Match{pattern=Dictionary, i=4, j=8, token=short, dictionaryName='english_wikipedia'}

Fixed in pull request #83

@vvatanabe
Copy link
Member

@mrFloony Thanks for PR! I will check it.

vvatanabe added a commit that referenced this issue Jan 26, 2021
Fix Error in method Feedback.getFeedback (#82)
@vvatanabe
Copy link
Member

@mrFloony I released 1.3.4 include #83. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants