Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with neovim stable due to use of lua-fs #1

Open
bjornsnoen opened this issue Aug 24, 2022 · 5 comments
Open

Incompatible with neovim stable due to use of lua-fs #1

bjornsnoen opened this issue Aug 24, 2022 · 5 comments

Comments

@bjornsnoen
Copy link

This module only works with vim nightly as it uses lua-fs in order to find the correct rc file. The offending code is here

@numToStr
Copy link
Owner

Yeah, I knowingly used vim.fs which is nightly only feature (as I am a nightly user). I'll put requirement on README.

@bjornsnoen
Copy link
Author

Alright, will this be a requirement for ever or will this be usable on stable from 0.8 going forward?

@numToStr
Copy link
Owner

numToStr commented Aug 24, 2022

Yes, vim.fs is technically a v0.8 API so you need to wait for it to be released as stable or use nightly for now if you can :)

@bjornsnoen
Copy link
Author

bjornsnoen commented Aug 24, 2022

Yeah, I more meant will you try to not use new nightly only APIs going forward? Say once 0.8 is out, some new feature is requested; would you try to only use stable APIs to implement or can we expect the following version of the plugin to again only work on nightly?

@numToStr
Copy link
Owner

will you try to not use new nightly only APIs going forward?

I also, almost, follow this principle unless something is really required like vim.fs. And the plugin is relatively stable, i hope, so I don't think any other nightly features will be required afterwards once 0.8 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants