Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: NumPy logo and favicon not loading in devdocs #19509

Closed
Mukulikaa opened this issue Jul 18, 2021 · 5 comments
Closed

DOC: NumPy logo and favicon not loading in devdocs #19509

Mukulikaa opened this issue Jul 18, 2021 · 5 comments

Comments

@Mukulikaa
Copy link
Contributor

I had a look in the developer console and it shows the paths for the images as https://numpy.org/devdocs/_static/_static/favicon/favicon.ico and https://numpy.org/devdocs/_static/_static/numpylogo.svg.

There is an extra _static in the paths. I am not sure in which file these paths are defined. If someone can guide me to it, I can look into the issue.

@manasux
Copy link

manasux commented Jul 18, 2021

I checked the developer console of devdocs. The path mentioned for logo is _static/_static/numpylogo.svg, but there is only one _static path inside it, and other than that, the logo image is missing in the whole source code, inside sources of developer console, but after filtering out "logo" in the network section, there is a numpylogo.svg, which is a 404 page svg.

@Mukulikaa
Copy link
Contributor Author

Mukulikaa commented Jul 18, 2021

Hi @manasux, the files do exist at doc/source/_static and you can see them rendered here and here.

I tried commenting out this line in doc/source/conf.py and it solves the problem. But I'm not sure if it's the right way to do it 🙂.

Edit: It seems to be an issue with Sphinx which has been solved in a newer release - sphinx-doc/sphinx/issues/9438

@melissawm
Copy link
Member

Thanks for chasing that down, @Mukulikaa - let's talk about this in the docs meeting.

@melissawm
Copy link
Member

SciPy has solved this in scipy/scipy#14417- we should probably do something similar.

@melissawm
Copy link
Member

Looks like dependabot fixed this for us - https://numpy.org/devdocs/ is now showing the logo and favicon again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants