BUG, SIMD: use scalar cmul on bad Apple clang x86_64 #24828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple clang 14.0.0 outputs code with non-deterministic behaviour for the AVX2-accelerated `multiply` ufunc on `complex64` and `complex128` for x86_64 on macOS with AVX2 enabled. This bug is fixed by Apple clang 14.0.3, but 14.0.0 is still commonly the available toolchain on CI images. In order to not output unsound code, this simply skips the SIMD version of the ufunc when using an affected compiler.
jakelishman
force-pushed
the
scalar-cmul-bad-apple-clang
branch
from
4f3ff78
to
012e048
Compare
charris
added a commit
to charris/numpy
that referenced
this pull request
Sep 28, 2023
* BUG, SIMD: use scalar cmul on bad Apple clang x86_64 Apple clang 14.0.0 outputs code with non-deterministic behaviour for the AVX2-accelerated `multiply` ufunc on `complex64` and `complex128` for x86_64 on macOS with AVX2 enabled. This bug is fixed by Apple clang 14.0.3, but 14.0.0 is still commonly the available toolchain on CI images. In order to not output unsound code, this simply skips the SIMD version of the ufunc when using an affected compiler. * MAINT: Formatting cleanup. --------- Co-authored-by: Charles Harris <charlesr.harris@gmail.com>
charris
added a commit
that referenced
this pull request
Sep 28, 2023
BUG, SIMD: use scalar cmul on bad Apple clang x86_64 (#24828)
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 11, 2023
* BUG, SIMD: use scalar cmul on bad Apple clang x86_64 Apple clang 14.0.0 outputs code with non-deterministic behaviour for the AVX2-accelerated `multiply` ufunc on `complex64` and `complex128` for x86_64 on macOS with AVX2 enabled. This bug is fixed by Apple clang 14.0.3, but 14.0.0 is still commonly the available toolchain on CI images. In order to not output unsound code, this simply skips the SIMD version of the ufunc when using an affected compiler. * MAINT: Formatting cleanup. --------- Co-authored-by: Charles Harris <charlesr.harris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple clang 14.0.0 outputs code with non-deterministic behaviour for the AVX2-accelerated
multiplyufunc oncomplex64andcomplex128for x86_64 on macOS with AVX2 enabled. This bug is fixed by Apple clang 14.0.3, but 14.0.0 is still commonly the available toolchain on CI images.In order to not output unsound code, this simply skips the SIMD version of the ufunc when using an affected compiler.
Fix #24000.