Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP50 Link is broken in devdocs #26371

Open
ernimd opened this issue May 2, 2024 · 4 comments · Fixed by #26527
Open

NEP50 Link is broken in devdocs #26371

ernimd opened this issue May 2, 2024 · 4 comments · Fixed by #26527

Comments

@ernimd
Copy link

ernimd commented May 2, 2024

https://github.com/numpy/numpy/blame/b2960879bbf90af0cc3e533d2721d3a30470b056/doc/source/release/2.0.0-notes.rst#L79

In the docs resolves to https://numpy.org/devdocs/release/NEP50

@melissawm
Copy link
Member

Our NEPs should be reachable via intersphinx mapping, so in this case we could use

:ref:`NEP 50 <NEP50>`

instead of

`NEP 50 <NEP50>`_.

to create a link. Would you be willing to submit a PR for this @ernimd ? Our contribution guidelines are here 😄

Just for information, I ran grep -R "NEP" in the doc/source folder and found a number of instances where neps are hardlinked instead of using the intersphinx mapping. Not sure if this is something we want to fix also?

@anushatomar13
Copy link

Hi, @melissawm
I would like to work on this issue. I have read the contribution guidelines. If the issue is not assigned already, could you please assign it to me?
Thanks

@melissawm
Copy link
Member

@anushatomar13 we do not assign issues, If you have a solution please submit your pull request. Thanks!

@anushatomar13
Copy link

@melissawm
I have created a pull request for the same. Please let me know if it looks fine or if any additional changes are required.
#26453

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants