-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: A fresh clone without submodules fails to build inscrutably #26397
Comments
Is there a reason why we don't have |
Because it's vendored, so pip can't handle it for us. Unless there's a way to do that with a vendored submodule. |
It still wouldn't be in build-requires if we didn't vendor it. It's only a transitive dependency;
I can make this one more informative - needs to be done in
This cannot be improved in either numpy or meson-python, and is user error that you only see if you invoke It does already raise |
Agreed, I was on the bubble of including this error but decided to. On second thought there's probably enough information, and you're right, using The really inscrutable errors happens when you don't have meson-python installed, or if you try to force meson-python to use a version of meson that's not the vendored one. One of the CPython developers hit this error while trying to build scikit-learn to understand a segfault in the scikit-learn tests and got very confused. |
Fixed by mesonbuild/meson-python#631, will be available in meson-python 0.17.0 |
It would be nice if the error message said something about initializing submodules and installing meson-python:
If meson-python is installed, we get this:
If it isn't, we get an error about
mesonpy
being missing:The text was updated successfully, but these errors were encountered: