Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicated input in explore #9128

Closed
PizzaKirby opened this issue May 7, 2023 · 2 comments · Fixed by #9139
Closed

duplicated input in explore #9128

PizzaKirby opened this issue May 7, 2023 · 2 comments · Fixed by #9139
Labels
needs-triage An issue that hasn't had any proper look tabled Issues about our new table renderer (tabled)
Milestone
v0.80.0

Comments

@PizzaKirby
Copy link

Describe the bug

Whenever I press a key in explore the character is inserted twice. (see attachment)

How to reproduce

  1. explore
  2. type anything

Expected behavior

I expected there to only be one character per keypress.

Screenshots

explore.webm

Configuration

key value
version 0.79.0
branch
commit_hash
build_os windows-x86_64
build_target x86_64-pc-windows-msvc
rust_version rustc 1.69.0 (84c898d65 2023-04-16)
rust_channel stable-x86_64-pc-windows-msvc
cargo_version cargo 1.69.0 (6e9a83356 2023-04-12)
build_time 2023-04-26 18:18:07 +02:00
build_rust_channel release
features default, zip
installed_plugins

Additional context

I am using Windows Terminal 1.16.10261.0
@PizzaKirby PizzaKirby added the needs-triage An issue that hasn't had any proper look label May 7, 2023
@amtoine amtoine mentioned this issue May 8, 2023
Closed
@fdncred
Copy link
Collaborator

fdncred commented May 8, 2023 •
edited

I can't reproduce this on my Mac. Although I've seen the exact problem with the latest crossterm somewhere else. But now that I think about it, maybe it was only on Windows. I'll try again on Windows later to see what happens.

@fdncred
Copy link
Collaborator

fdncred commented May 8, 2023

@zhiburt Yup, this is a problem only on windows. Can you please help us fix it? I found this issue in the crossterm repo crossterm-rs/crossterm#772

@fdncred fdncred added the tabled Issues about our new table renderer (tabled) label May 8, 2023
@zhiburt zhiburt mentioned this issue May 8, 2023
Merged
fdncred added a commit that referenced this issue May 8, 2023
@zhiburt @fdncred
nu-explore: Fix repeated char issue in cmdline (#9139)
a5d02a0 
Must be fixed; (though I'd test it)

Thanks for the reference [fdncred](https://github.com/fdncred).

close #9128

---------

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
@hustcer hustcer added this to the v0.80.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage An issue that hasn't had any proper look tabled Issues about our new table renderer (tabled)
Projects
None yet
Milestone
v0.80.0
Development

Successfully merging a pull request may close this issue.

nu-explore: Fix repeated char issue in cmdline zhiburt/nushell
3 participants
@fdncred @hustcer @PizzaKirby