Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable cursor shape #514

Closed
dead10ck opened this issue Nov 14, 2022 · 2 comments · Fixed by #515
Closed

Configurable cursor shape #514

dead10ck opened this issue Nov 14, 2022 · 2 comments · Fixed by #515
Labels
enhancement New feature or request

Comments

@dead10ck
Copy link

#494 changed the cursor shape in insert mode to a vertical bar. I have a preference for the block shape, but it looks like it was merged without any way to configure the cursor shape, so I am unable to change it back without just using an older nushell version. I'm kind of surprised this was merged without a configuration option; this is kind of like changing everyone's color scheme without a way to change it back. It's a highly personal preference.
@dead10ck dead10ck added the enhancement New feature or request label Nov 14, 2022
@cschierig cschierig mentioned this issue Nov 18, 2022
Merged
@Zaechus
Copy link

Zaechus commented Nov 23, 2022

Using the text-based version of the game Angband as an example:
image
image

The behavior of forcing the cursor shape bleeds through to all applications. You also can't set the cursor shape through your terminal.

nushell issue

sholderbach pushed a commit that referenced this issue Dec 21, 2022
@cschierig
Make reedline handling cursor shapes more configurable (#515)
475495d 
Adds a struct to configure the cursor shape

Co-authored-by: sholderbach <sholderbach@users.noreply.github.com>
resolve #514
@dead10ck
Copy link
Author

Thank you! ♥️ Your work is appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make reedline handling cursor shapes more configurable
2 participants
@dead10ck @Zaechus