Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加单元测试 #503

Open
1 of 5 tasks
elliotchenzichang opened this issue Nov 26, 2023 · 12 comments
Open
1 of 5 tasks

添加单元测试 #503

elliotchenzichang opened this issue Nov 26, 2023 · 12 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@elliotchenzichang
Copy link
Member

elliotchenzichang commented Nov 26, 2023

目前从codecov的结果来看,我们的单元测试覆盖率为71%左右。想请想要了解和上手这个项目的小伙伴来优化一下单元测试覆盖率。放方便上手这个项目。这个issue要做的内容包括有。

@elliotchenzichang elliotchenzichang added the help wanted Extra attention is needed label Nov 26, 2023
@hunknownz
Copy link

我来做 tarDecompress 这个任务,@hunknownz

@bigboss2063
Copy link
Member

我来做 tarDecompress 这个任务,@hunknownz

Thanks!

@elliotchenzichang elliotchenzichang self-assigned this Nov 27, 2023
@xiaolin820
Copy link
Contributor

我来做 ZPeekMax 这个任务,@xiaolin820

@bigboss2063
Copy link
Member

我来做 ZPeekMax 这个任务,@xiaolin820

Thanks!

@dreamjz
Copy link
Contributor

dreamjz commented Nov 27, 2023

https://app.codecov.io/gh/nutsdb/nutsdb/blob/master/tx_zset.go 函数:ZPeekMin

I'd like to do this.

@bigboss2063
Copy link
Member

https://app.codecov.io/gh/nutsdb/nutsdb/blob/master/tx_zset.go 函数:ZPeekMin

I'd like to do this.

Thanks!

@bigboss2063 bigboss2063 added the good first issue Good for newcomers label Nov 30, 2023
@her-cat
Copy link
Contributor

her-cat commented Dec 6, 2023

我来做 ZKeys 这个任务,@her-cat

@bigboss2063
Copy link
Member

我来做 ZKeys 这个任务,@her-cat

Thanks, assigned it to you.

@hunknownz
Copy link

hunknownz commented Dec 14, 2023

@bigboss2063

tarDecompress 暂时是一段没有被用到的代码,并且是一个 Unexported 的方法,确认一下是否需要给它写单元测试?

@bigboss2063
Copy link
Member

@bigboss2063

tarDecompress 暂时是一段没有被用到的代码,并且是一个 Unexported 的方法,确认一下是否需要给它写单元测试?

这个方法有用户测出来有 bug,提了一个 pr 在修复,但是还没有合进去,可以稍微等一下这个方法的修复

@ReigenDing
Copy link

ReigenDing commented Dec 19, 2023

Could I try this https://app.codecov.io/gh/nutsdb/nutsdb/blob/master/tx_zset.go 函数: ZRangeByScore @her-cat ?

@her-cat
Copy link
Contributor

her-cat commented Dec 19, 2023

@ReigenDing Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants