Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing too many API that should be private #530

Open
bigboss2063 opened this issue Dec 9, 2023 · 6 comments
Open

Exposing too many API that should be private #530

bigboss2063 opened this issue Dec 9, 2023 · 6 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bigboss2063
Copy link
Member

Since the current nutsdb package structure is flat, all internal methods and variables can be changed to private, and only part of the user API should be exposed.

For example, The method SubmitBucket in tx.go should rename to submitBucket.

@bigboss2063 bigboss2063 added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 9, 2023
@ziscky
Copy link

ziscky commented Dec 11, 2023

Hey, I would like to work on this issue.

@bigboss2063
Copy link
Member Author

Hey, I would like to work on this issue.

Assigned to you. Thanks.😁

@ziscky
Copy link

ziscky commented Dec 12, 2023

Hey @bigboss2063 PR is ready, should I also have changed the internal types e.g Event, Record to be unexported ? I left them as is but I changed the creator methods to newEvent and newRecord

@bigboss2063
Copy link
Member Author

Hey @bigboss2063 PR is ready, should I also have changed the internal types e.g Event, Record to be unexported ? I left them as is but I changed the creator methods to newEvent and newRecord

yeap. I think we should change them all.

@ziscky
Copy link

ziscky commented Dec 12, 2023

@bigboss2063 I think PR is ready now with the extra changes

@bigboss2063
Copy link
Member Author

Wow! It's a very big change. I need some time to review🤣.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants